Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OpenXLA|TSL] Replace tsl::Status to absl::Status in profiler.h/.cc #6655

Merged
merged 26 commits into from
Mar 7, 2024
Merged

[OpenXLA|TSL] Replace tsl::Status to absl::Status in profiler.h/.cc #6655

merged 26 commits into from
Mar 7, 2024

Conversation

ManfeiBai
Copy link
Collaborator

@ManfeiBai ManfeiBai commented Mar 1, 2024 •
edited
Loading

pre-change =for #6535

cc @ddunl

@ManfeiBai ManfeiBai added the tsl label Mar 1, 2024
@ManfeiBai ManfeiBai changed the title [test] Replace tsl::Status to absl::Status in profiler.h [test] Replace tsl::Status to absl::Status in profiler.h/.cc Mar 1, 2024
@ManfeiBai ManfeiBai changed the title [test] Replace tsl::Status to absl::Status in profiler.h/.cc [test][OpenXLA|TSL] Replace tsl::Status to absl::Status in profiler.h/.cc Mar 1, 2024
@ManfeiBai ManfeiBai changed the title [test][OpenXLA|TSL] Replace tsl::Status to absl::Status in profiler.h/.cc [OpenXLA|TSL] Replace tsl::Status to absl::Status in profiler.h/.cc Mar 6, 2024
@ManfeiBai ManfeiBai marked this pull request as ready for review March 6, 2024 09:19
will-cromar
will-cromar approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@will-cromar will-cromar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be using absl::Status or xla::Status going forward? I see a few references to xla::Status remaining. I assuming this is just an alias.

@ManfeiBai
Copy link
Collaborator Author

Should we be using absl::Status or xla::Status going forward? I see a few references to xla::Status remaining. I assuming this is just an alias.

nice point, since xla::Status looks like an alias of absl::Status: link, let's try to use xla::Status too

@ManfeiBai ManfeiBai merged commit 13dc9df into master Mar 7, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@will-cromar will-cromar will-cromar approved these changes

@miladm miladm Awaiting requested review from miladm

Assignees
No one assigned
Labels
q1_2024_manfei tsl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ManfeiBai @will-cromar